Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbac: update permissions definition to accept weaviate resource #6266

Merged
merged 1 commit into from
Nov 8, 2024
Merged

rbac: update permissions definition to accept weaviate resource #6266

merged 1 commit into from
Nov 8, 2024

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented Nov 8, 2024

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

tsmith023
tsmith023 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@tsmith023 tsmith023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a ST collection, will the permissions retrieved in GET /authz/roles have tenant: "*" or tenant: nil? Might this need to be a point of difference between the input and output Permissions objects?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@moogacs
Copy link
Contributor Author

moogacs commented Nov 8, 2024

the response we will rebuild from path and return what exists only
because for example object , tenant filter won't exists on permission read_collections for example but instead it will be collection=* or collection=ABC

@moogacs moogacs merged commit 068ee19 into main Nov 8, 2024
53 checks passed
@moogacs moogacs deleted the rbac-permission branch November 8, 2024 14:43
@BrewTestBot BrewTestBot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moogacs @tsmith023