Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Don't require an UID in manifests in GitOps mode #191

Open
luxas opened this issue Jul 16, 2019 · 5 comments
Open

Don't require an UID in manifests in GitOps mode #191

luxas opened this issue Jul 16, 2019 · 5 comments
Assignees
Labels
area/UX Let's make Ignite's UX great! kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Contributor

luxas commented Jul 16, 2019

Instead, generate it on the fly.
We could e.g. use the first 16 chars off sha256sum of the name :)

@luxas luxas added this to the v0.4.2 milestone Jul 16, 2019
@luxas luxas added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Jul 16, 2019
@luxas luxas added area/UX Let's make Ignite's UX great! priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 16, 2019
@twelho
Copy link
Contributor

twelho commented Jul 16, 2019

We could e.g. use the first 16 chars off sha256sum of the name :)

For consistency, I would for now use the build in UID generator which also ensures uniqueness. In the long term however basing UIDs from name SHAs could be a valid option.

@luxas
Copy link
Contributor Author

luxas commented Jul 16, 2019

For consistency, I would for now use the build in UID generator which also ensures uniqueness

There is the problem that if we generate a new UID every time we see the object, it's gonna be recreated/etc. for every new commit. We need "stable" generation of UIDs, hence.
We should also make the UIDs themselves a bit longer IMO

@luxas
Copy link
Contributor Author

luxas commented Jul 16, 2019

@twelho pointed out that this isn't easily possible with the current architecture. We will move this to v0.5.0 along with the other, larger changes in the storage backend.

@luxas luxas modified the milestones: v0.4.2, v0.5.0 Jul 16, 2019
@luxas
Copy link
Contributor Author

luxas commented Aug 2, 2019

I'm gonna move this out; for now it's a reasonable requirement to require the UID being in the files you post to Git.

@luxas luxas modified the milestones: v0.5.0, Next Aug 2, 2019
@stealthybox
Copy link
Contributor

Just noting here that we can have good default logic for this when the user provides a name but no UID.

However, if a user provides a UID, we should use it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/UX Let's make Ignite's UX great! kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants