Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-1909 new SDK function - set_secret #16

Merged
merged 13 commits into from
Nov 29, 2022
Merged

GEN-1909 new SDK function - set_secret #16

merged 13 commits into from
Nov 29, 2022

Conversation

hrgreene
Copy link
Contributor

@hrgreene hrgreene commented Nov 16, 2022 •
edited
Loading

Change description

New SDK function, allows process running on wayscript to create or update a secret

from wayscript import secret_manager

secret_manager.set_secret("key", "value")

Checklist

  • Application changes have been tested and automated tests have been added, if applicable
  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Related issues

Fixes #1909

@linear
Copy link

linear bot commented Nov 16, 2022

GEN-1909 Endpoint for updating secrets

Add this to both python and node SDK

samkam
samkam approved these changes Nov 16, 2022
View reviewed changes
Copy link

@samkam samkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aroxby-wayscript
aroxby-wayscript reviewed Nov 17, 2022
View reviewed changes
Copy link

@aroxby-wayscript aroxby-wayscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! A little cleanup suggested.

src/wayscript/secret_manager.py Outdated Show resolved Hide resolved
src/wayscript/secret_manager.py Outdated Show resolved Hide resolved
tests/test_secret_manager.py Outdated Show resolved Hide resolved
aroxby-wayscript
aroxby-wayscript suggested changes Nov 17, 2022
View reviewed changes
src/wayscript/secret_manager.py Outdated Show resolved Hide resolved
tests/test_secret_manager.py Outdated Show resolved Hide resolved
aroxby-wayscript
aroxby-wayscript approved these changes Nov 17, 2022
View reviewed changes
Copy link

@aroxby-wayscript aroxby-wayscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hrgreene hrgreene merged commit 3394488 into master Nov 29, 2022
@hrgreene hrgreene deleted the GEN-1909-update-secret-via-sdk branch November 29, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffbuswell jeffbuswell jeffbuswell left review comments

@samkam samkam samkam approved these changes

@aroxby-wayscript aroxby-wayscript aroxby-wayscript approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrgreene @samkam @jeffbuswell @aroxby-wayscript