Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh token impl #2212

Open
wants to merge 6 commits into
base: miho-login-hooks
Choose a base branch
from
Open

Refresh token impl #2212

wants to merge 6 commits into from

Conversation

infomiho
Copy link
Contributor

@infomiho infomiho commented Jul 30, 2024

Closes #2124

What was done

  • Moved init of OAuth clients (google, github, discord and keycloak) to the SDK so users can also import them and use them
    • These clients are needed to refresh auth tokens
  • Move some of the OAuth helpers to SDK - because they are only used in the SDK or could be useful for users
    • The env helpers are only used in the SDK
    • The redirect and one-time token helpers can be useful if users implement some OAuth client themselves
  • Updated the OAuth tokens that we provide in auth hooks: we now provide all the data we get and not just the access token
    • We forward the data we receive so users will get the refresh token if we receive it

Left to do

  • Update docs

@infomiho infomiho marked this pull request as ready for review July 31, 2024 12:26
@infomiho infomiho requested a review from sodic August 2, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant