Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to store private non-source files #2175

Open
sodic opened this issue Jul 11, 2024 · 4 comments
Open

Allow users to store private non-source files #2175

sodic opened this issue Jul 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@sodic
Copy link
Contributor

sodic commented Jul 11, 2024

We should give users a way to store private non-source files that the app uses (like the public dir, only private).

Motivation

From the message: https://discord.com/channels/686873244791210014/1260392522761371659/1260392522761371659

Is there a way to reference a google cloud key.json file after compiling? I currently have it placed in the /app directory and storing that path to the key as an .env var. Is there a way to make sure that file is also moved into the compiled project after running wasp start? Thanks for your help!

Thanks for the feedback, Connor!

@sodic sodic added the enhancement New feature or request label Jul 11, 2024
@infomiho
Copy link
Contributor

Related to #1564

@Martinsos
Copy link
Member

SO not Wasp app users but Wasp framework users! Maybe we should say Wasp devs, not sure.

This is interesting use case. I think it falls under secret management. We have plans to make it easier to do this for .env files. But it could be used for other files also. I wonder what is the best practice though. They key.json -> I imagine it might be better to take its contents/value and just put it directly into .env.server, why woudln't that be the solution? Soudns a bit unusual to keep that file around. Is there a standardized way of dealing with that key.json file? What does Google Cloud recommend?

@sodic
Copy link
Contributor Author

sodic commented Jul 12, 2024

SO not Wasp app users but Wasp framework users!

Yes, this trips me up all the time. When I say users, I usually mean Wasp framework users, and for Wasp app users I say "Wasp app users."

When I hear "Wasp devs", I think about the three of us 😄

I don't know what to do, but we can agree on something and make it consistent.

@sodic
Copy link
Contributor Author

sodic commented Jul 12, 2024

As for the keys.json specifically - I have no idea what the best practice is (maybe it's indeed better to just use an env variable). That's what I told Connor to do in Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants