Implement bulk-memory Wasm proposal
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are currently all failing obviously since bulk-memory has not yet been implemented. The goal is to implement bulk-memory until all tests pass in this PR.
Those errors are now panics which makes more sense considering the fact that the wasmparser crate already filters out all of those items unless there is a bug. And if there is a bug we should panic instead of properly managing the error.
BENCHMARKS
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Now 3 of the 8 bulk-memory Wasm spec tests pass!
Many tests are failing now. Next steps are to make them pass again.
Robbepop
changed the title
bulk-memory Wasm proposalbulk-memory Wasm proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364.
This PR also updates the Wasm spec testsuite to a much more recent version where
bulk-memory´ andreference-typesare already included as stable components of the Wasm standard. However, sincewasmidoes not yet supportreference-types` that means that we had to expect failures for a subset of the Wasm spec testsuite tests temporarily.We are going to merge this PR and immediately create a follow-up PR that implements the
reference-typesWasm proposal in order to make those tests pass again.