Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Wasmi differential fuzzing #1257

Merged
merged 22 commits into from
Oct 26, 2024
Merged

Modernize Wasmi differential fuzzing #1257

merged 22 commits into from
Oct 26, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Oct 25, 2024 •
edited
Loading

Closes #896.

  • New differential fuzzer now always fuzzes one arbitrarily chosen oracle (Wasmi (stack) or Wasmtime for now) in each iteration.
  • Non-deterministic errors are now properly handled.
  • All non-trivial implementation details reside in the new wasmi_fuzz crate which is better for maintenance.
    • This makes it much simpler to add new differential fuzzing oracles, e.g. Wasmer.
  • Global state (globals and memory) are now properly checked for runs which are deterministic.
  • Function call parameters are now arbitrarily chosen.

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 367 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (c33ccf7) to head (c6bea90).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/fuzz/src/oracle/wasmi.rs 0.00% 104 Missing ⚠️
crates/fuzz/src/oracle/wasmi_stack.rs 0.00% 101 Missing ⚠️
crates/fuzz/src/oracle/wasmtime.rs 0.00% 92 Missing ⚠️
crates/fuzz/src/oracle/exports.rs 0.00% 32 Missing ⚠️
crates/fuzz/src/value.rs 0.00% 21 Missing ⚠️
crates/fuzz/src/oracle/mod.rs 0.00% 15 Missing ⚠️
crates/fuzz/src/error.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1257       /-   ##
==========================================
- Coverage   81.40%   80.30%   -1.11%     
==========================================
  Files         307      312        5     
  Lines       25211    25559      348     
==========================================
  Hits        20523    20524        1     
- Misses       4688     5035      347

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop marked this pull request as ready for review October 26, 2024 11:29
@Robbepop Robbepop merged commit 93e8898 into main Oct 26, 2024
17 of 19 checks passed
@Robbepop Robbepop deleted the rf-refactor-differential-fuzzer branch October 26, 2024 11:33
@Robbepop Robbepop mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean-up differential fuzzing infrastructure
1 participant
@Robbepop