Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the Player's style to Fusion for OS X; #738 #741

Merged
merged 1 commit into from
Oct 1, 2016
Merged

set the Player's style to Fusion for OS X; #738 #741

merged 1 commit into from
Oct 1, 2016

Conversation

r-a-v-a-s
Copy link
Contributor

The cross-platform Qt5 style "Fusion" timeline indicator does not suffer from issue #738
which implies this is an upstream issue.

I did find a couple bug reports that seem similar...
and one notes it's OS X / Retina specific,
which is what I'm using.
https://bugreports.qt.io/browse/QTBUG-48084

@r-a-v-a-s
set the Player's style to Fusion for OS X; #738
5b3d8f2 
This is a work-around for the broken slider in the default Macintosh
style.
@wang-bin
Copy link
Owner

QSlider::sliderPressed() is broken in Fusion style

@r-a-v-a-s
Copy link
Contributor Author

r-a-v-a-s commented Sep 30, 2016 •
edited
Loading

How can I test that? Everything seems to work for me. Qt 5.6.1

@r-a-v-a-s
Copy link
Contributor Author

Testing shows that seek(int), connected with sliderMoved(int), is called first,
then seek(), connected with sliderPressed(), is called.

Actually connect(mpTimeSlider, SIGNAL(sliderPressed()), SLOT(seek())); seems unnecessary.
When I remove that, I can still click on the slider and have it properly change position,
and I can also drag the indicator.

@wang-bin
Copy link
Owner

wang-bin commented Oct 1, 2016

Nothing happens when I pressed on the slider. You can test simpleplayer example too.

@r-a-v-a-s
Copy link
Contributor Author

Fusion works perfectly for me on the Player,
but does have the problem you mention on simpleplayer...

The default style is broken for me on the Player (issue 738),
and works perfectly for me on the simpleplayer.

😲 OS X 10.11.6, XCode 8, Qt 5.6.1

@wang-bin
Copy link
Owner

wang-bin commented Oct 1, 2016

I forgot to remove some changes. It works now.

@wang-bin wang-bin merged commit 8465075 into wang-bin:master Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-a-v-a-s @wang-bin