Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make install with alernate root path #1286

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix make install with alernate root path #1286

merged 1 commit into from
Mar 11, 2020

Conversation

maxrd2
Copy link
Contributor

@maxrd2 maxrd2 commented Mar 9, 2020

This fixes make install (qmake) to fake root path which is needed to create packages.
When building with qmake and doing make install to different root path (in this case /home/max/projects/KDE/craft), operation was failing with:

cd install_sdk/ && ( test -e Makefile || /home/max/projects/KDE/craft/bin/qmake -o Makefile /home/max/projects/KDE/craft/download/git/libs/qtav/tools/install_sdk/install_sdk.pro 'CONFIG  = no-examples no-tests' 'CONFIG -= debug' 'CONFIG  = release' 'CONFIG  = no-examples no-tests' 'CONFIG -= debug' 'CONFIG  = release' ) && /bin/make -f Makefile install
make[1]: Entering directory '/home/max/projects/KDE/craft/build/libs/qtav/work/build/src'
...
make[2]: Entering directory '/home/max/projects/KDE/craft/build/libs/qtav/work/build/tools/install_sdk'
...
/home/max/projects/KDE/craft/bin/qmake -install qinstall /home/max/projects/KDE/craft/download/git/libs/qtav/src/QtAV.svg /usr/share/icons/hicolor/scalable/apps/QtAV.svg
/home/max/projects/KDE/craft/bin/qmake -install qinstall /home/max/projects/KDE/craft/download/git/libs/qtav/src/QtAV/Geometry.h /home/max/projects/KDE/craft/include/qt5/QtAV/Geometry.h
make[2]: Leaving directory '/home/max/projects/KDE/craft/build/libs/qtav/work/build/tools/install_sdk'
Error copying /home/max/projects/KDE/craft/download/git/libs/qtav/src/QtAV.svg to /usr/share/icons/hicolor/scalable/apps/QtAV.svg: Cannot create /usr/share/icons/hicolor/scalable/apps/QtAV.svg for output
/home/max/projects/KDE/craft/bin/qmake -install qinstall /home/max/projects/KDE/craft/download/git/libs/qtav/src/QtAV/private/OpenGLRendererBase_p.h /home/max/projects/KDE/craft/include/qt5/QtAV/5.14.1/QtAV/private/OpenGLRendererBase_p.h
make[1]: *** [Makefile.libQtAV:15750: install_icon] Error 3
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/max/projects/KDE/craft/build/libs/qtav/work/build/tools'

@wang-bin wang-bin merged commit a20b33d into wang-bin:master Mar 11, 2020
@maxrd2 maxrd2 deleted the install-fix branch April 6, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxrd2 @wang-bin