This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Merge 3.0 and integrate http package for rest v2 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericBregier
suggested changes
Jun 14, 2019
|
It is always a good practice to propagate fixes upstream.
As for the inclusion of the library in the codebase, we were looking for a
"quick" (and dirty, I admit) solution to add compatibility for Java 6,
given that the compatibility with Java 6 will be dropped with a 4.0 version
of Waarp R66. The release of this major milestone is yet to be planned, but
it will arrive within two years top. The inclusion of netty-http will be
dropped then, and will be included as a "regular" dependency.
This is just a temporary solution.
Le mar. 18 juin 2019 à 13:27, Frédéric Brégier <[email protected]> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In src/main/java/io/cdap/http/AbstractHandlerHook.java
<#114 (comment)>:
> * Copyright © 2014-2019 Cask Data, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package io.cdap.http;
At least in the meantime, we could only kept the changed files (not to
many) and only source ones, not the test ones (and upgrading dependencies
in our pom).
- src/main/java/io/cdap/http/AbstractHttpResponder.java
- src/main/java/io/cdap/http/NettyHttpService.java
- src/main/java/io/cdap/http/SSLHandlerFactory.java
- src/main/java/io/cdap/http/internal/BasicHttpResponder.java
- src/main/java/io/cdap/http/internal/HandlerException.java
- src/main/java/io/cdap/http/internal/HttpResourceHandler.java
- src/main/java/io/cdap/http/internal/HttpResourceModel.java
- src/main/java/io/cdap/http/internal/ImmutablePair.java
- src/main/java/io/cdap/http/internal/ParamConvertUtils.java
- src/main/java/io/cdap/http/internal/PatternPathRouterWithGroups.java
so 10 files instead of 36 files plus test files. It should be easier to
follow the evolution until the merge is done.
WDYT?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#114?email_source=notifications&email_token=AAEPKCKXTG6PNMQGFVAK453P3DBD5A5CNFSM4HYHYHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB33FQHI#discussion_r294741672>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEPKCMSQDY2W7AIXPOHW63P3DBD5ANCNFSM4HYHYHVQ>
.
|
I understand the reason, of course. In the meantime, we could just import the tagged files (10 of them) instead of all... WDYT? |
fredericBregier
approved these changes
Jun 19, 2019
bcarlin
suggested changes
Jun 19, 2019
| getSession().useConnection(); // default since this is the top | ||
| // connection | ||
| return; | ||
| } |
There was a problem hiding this comment.
KISS!
The only difference between the two branches of the if is the value of isReadOnly, which is, in fact !write. the if is useless.
fredericBregier
suggested changes
Jun 19, 2019
fredericBregier
approved these changes
Jul 2, 2019
|
Is DbAdmin on its way to be removed ? if so, I'm OK with this PR. |
bcarlin
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the fixes developed on branch 3.0
Add a modified netty-http compatible with java6