Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML comments from extracting htmlProse for definitions #1452

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

dontcallmedom
Copy link
Member

Avoid bloat, esp. since ReSpec use comments expansively

Avoid bloat, esp. since ReSpec use comments expansively
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truth be told, I thought createNodeIterator was a new method. ;)
I'm not so far from the truth, it wasn't in DOM Level 2 Core!

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, it would be good to write a short test about that, I'll add one.

@tidoust tidoust merged commit ed1b3d8 into main Dec 21, 2023
1 check passed
@tidoust tidoust deleted the fix-dfn-prose branch December 21, 2023 14:44
tidoust added a commit that referenced this pull request Jan 15, 2024
Bugs fixed:
- [IDL extraction] Ignore asides added by Bikeshed (#1463)
- Remove HTML comments from extracting htmlProse for definitions (#1452)

Dependencies bumped:
- Bump rollup from 4.9.1 to 4.9.5 (#1462)
- Bump puppeteer from 21.6.1 to 21.7.0 (#1458)
- Bump undici from 6.2.0 to 6.3.0 (#1461)
- Bump respec from 34.2.2 to 34.3.0 (#1454)
- Bump web-specs from 2.75.1 to 2.76.0 (#1455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants