Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore links insided elements #1428

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Ignore links insided elements #1428

merged 1 commit into from
Nov 23, 2023

Conversation

dontcallmedom
Copy link
Member

With W3C Recs that embed their diff for candidate or proposed corrections, we can expect more and more specs to have links-that-aren't-meant-to-be links, which this patch allows to ignore.

See w3c/strudy#439 (review) for a concrete example this would help fix

With W3C Recs that embed their diff for candidate or proposed corrections, we can expect more and more specs to have links-that-aren't-meant-to-be links, which this patch allows to ignore.

See w3c/strudy#439 (review) for a concrete example this would help fix
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that partly addresses #932. There are probably other areas that we need to check to skip del sections more consistently.

@tidoust tidoust merged commit 6af05ad into main Nov 23, 2023
1 check passed
@tidoust tidoust deleted the manage-deleted-links branch November 23, 2023 07:05
tidoust added a commit that referenced this pull request Nov 24, 2023
Feature improvement:
- Ignore links inside `<del>` elements (#1428)

Dependencies bumped:
- Bump web-specs from 2.74.0 to 2.74.1 (#1430)
- Bump rollup from 4.4.1 to 4.5.2 (#1431)
- Bump undici from 5.27.2 to 5.28.0 (#1429)
- Bump respec from 34.2.1 to 34.2.2 (#1425)
- Bump puppeteer from 21.5.1 to 21.5.2 (#1424)

The new version of web-specs flags a few IETF RFCs as discontinued (RFC7230 to
RFC7235, RFC7538, RFC7540), which means that Reffy will no longer crawl them by
default. This is correct but means specs that reference terms in those
specifications need to be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants