Drop legacyValue extraction logic #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #1215, the `legacyValue` logic is no longer needed since CSS Color 4 no longer uses it. The /TR version of the spec still uses it but... the code stopped working a few months ago when we switched to function names without surrounding `<>`, meaning that Webref data already does not have `legacyValue` anymore. This update drops that custom logic entirely. Code continues to concatenate values if more than one definition is found.
dontcallmedom
approved these changes
Feb 24, 2023
tidoust
added a commit
that referenced
this pull request
Feb 24, 2023
Breaking change: - Skip non-published specs when "--release" option is set (#1214) The change is breaking in that a crawl on released versions of specs no longer contains info about specs that do not have a released version. For example, specs that only exist as living standards such as WHATWG specs are no longer crawled when the `--release` option is set. The `--release` option is typically used to run a crawl that completes a crawl on the nightly versions of specs. Goal of the change is to avoid crawling specs that are already in the nightly crawl. Crawl results are unaltered otherwise. Tools that use Reffy should only need to update their logic if they expect a `--release` crawl to also yield info about non-released specs. Feature patches: - ECMAScript spec: Fix dfn scoping and abstract op extraction (#1217) - Drop legacyValue extraction logic (#1218) - Encode URI fragments (#1216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1215, the
legacyValuelogic is no longer needed since CSS Color 4 no longer uses it. The /TR version of the spec still uses it but... the code stopped working a few months ago when we switched to function names without surrounding<>, meaning that Webref data already does not havelegacyValueanymore.This update drops that custom logic entirely. Code continues to concatenate values if more than one definition is found.