Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-shapes] Why does this spec need to special-case serialization of <position>? #2301

Closed
emilio opened this issue Feb 12, 2018 · 4 comments
Closed

[css-shapes] Why does this spec need to special-case serialization of <position>? #2301

emilio opened this issue Feb 12, 2018 · 4 comments
Labels
Closed Accepted by CSSWG Resolution css-shapes-1 Current Work Needs Testcase (WPT)

Comments

@emilio
Copy link
Collaborator

emilio commented Feb 12, 2018

See web-platform-tests/wpt#9339 (comment).

The spec says:

The values (including the defaults) in ellipse() and circle() serialize to their 2- and 4-value forms only, preferring the 2-value form when it can be expressed without calc(), preferring left and top origins, and preferring 0% over a zero length.

Firefox right now special-cases that to follow the spec, but I think it'd be more sane and consistent to just use the regular serialization. Is there any reason that sentence was added to the spec?
@emilio
Copy link
Collaborator Author

emilio commented Feb 12, 2018

This is https://drafts.csswg.org/css-shapes/#basic-shape-serialization, btw.

@fantasai fantasai added the css-shapes-1 Current Work label Feb 14, 2018
@fantasai
Copy link
Collaborator

See related issue in #2274 ...

@ewilligers ewilligers mentioned this issue Apr 9, 2018
Merged
@ewilligers
Copy link
Contributor

This has been resolved in
#2274 (comment)
and the spec should be updated by removing the relevant language from the shapes spec. All <position> values serialize the same way.

@astearns
Copy link
Member

I've removed the wrong text from css-shapes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution css-shapes-1 Current Work Needs Testcase (WPT)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fantasai @ewilligers @emilio @astearns