Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readAsDataURL should be more precise about the data URL contents #104

Open
domenic opened this issue Jun 20, 2018 · 2 comments
Open

readAsDataURL should be more precise about the data URL contents #104

domenic opened this issue Jun 20, 2018 · 2 comments

Comments

@domenic
Copy link
Contributor

domenic commented Jun 20, 2018

In particular, it appears all browsers base64-encode the contents; see jsdom/jsdom#2269 for the original report.

Probably it'd be best to give the exact algorithm for creating the string from the contents of the type attribute and the bytes of the Blob.
@annevk
Copy link
Member

annevk commented Jun 21, 2018

See also whatwg/fetch#665 which this would tie into (if someone wants to work on that, feel free, happy to assist).

@inexorabletash
Copy link
Member

Re: "creating the string from the contents of the type attribute" - just a note in case someone tackles this. Beware of the gotcha associated with #43 - namely, as the spec is currently written, the value returned by the type attribute's getter and the internal type of the blob (which isn't clearly documented) differ if the type is not a parseable MIME type.

@mkruisselbrink mkruisselbrink mentioned this issue Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @inexorabletash @annevk