Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): add 'inert' attribute to prevent unnecessary traversal of hidden content #3392

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

feat(theme): add 'inert' attribute to prevent unnecessary traversal of hidden content #3392

wants to merge 18 commits into from

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented Dec 30, 2023 •
edited
Loading

Same as the original #2932 but providing global inert controls and state (both exported in default theme).

Also included focusTrap in outline (On this page) popup.

@userquin userquin changed the title feat: add again inert content on narrow for narrow screens feat: add again inert content on narrow screens Dec 30, 2023
userquin
userquin commented Dec 30, 2023
View reviewed changes
src/client/app/inert.ts Outdated Show resolved Hide resolved
@userquin userquin marked this pull request as ready for review December 30, 2023 21:05
@userquin userquin marked this pull request as draft December 30, 2023 21:28
@userquin
Copy link
Collaborator Author

Sidebar not woking...

@userquin userquin marked this pull request as ready for review December 30, 2023 23:13
@userquin userquin requested a review from brc-dd December 30, 2023 23:13
@userquin
Merge branch 'main' into userquin/feat-add-inert-content-again
43202d0 
# Conflicts:
#	src/client/theme-default/composables/sidebar.ts
#	src/node/plugin.ts
@userquin userquin marked this pull request as draft January 3, 2024 20:14
@userquin userquin marked this pull request as ready for review January 3, 2024 21:07
@brc-dd brc-dd force-pushed the userquin/feat-add-inert-content-again branch 2 times, most recently from 5aa35f4 to 2a38b78 Compare January 4, 2024 14:14
@brc-dd brc-dd changed the title feat: add again inert content on narrow screens feat: add inert to avoid traversing other menus and content when one is open Jan 4, 2024
@brc-dd brc-dd changed the title feat: add inert to avoid traversing other menus and content when one is open feat(theme): add 'inert' attribute to prevent unnecessary traversal of hidden content Jan 4, 2024
@brc-dd brc-dd marked this pull request as draft January 4, 2024 20:46
@github-actions github-actions bot added the stale label Feb 15, 2024
@userquin
Merge branch 'refs/heads/main' into userquin/feat-add-inert-content-a…
24119f7 
…gain

# Conflicts:
#	src/client/theme-default/components/VPNavBar.vue
#	src/client/theme-default/composables/sidebar.ts
@userquin
chore: resolve conflicts
6c2ac4a
@userquin userquin removed the stale label Apr 14, 2024
@userquin userquin mentioned this pull request Apr 14, 2024
Draft
@github-actions github-actions bot added the stale label May 23, 2024
@github-actions github-actions bot removed the stale label Jul 17, 2024
@github-actions github-actions bot added the stale label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brc-dd brc-dd brc-dd left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@userquin @brc-dd