fix(runtime-core): force evalutating SetupContext type (fix #2362) #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vuejs-coverage failed.
|
cexbrayat
added a commit
to cexbrayat/vue-test-utils-next
that referenced
this pull request
Feb 2, 2023
A change of types in core (vuejs/core#2818) introduced a TS compilation error when bumping to Vue v3.2.47. I couldn't figure out a proper way to fix, but using `EmitOptions` instead of `E` (which extends `EmitOptions`...) fixes the issue. It may be good enough to allow to update to the latest Vue releases, and I think it should have minimal impact on our users (or none at all).
lmiller1990
pushed a commit
to vuejs/test-utils
that referenced
this pull request
Feb 2, 2023
* chore(deps): update all non-major dependencies * fix: TS workaround for Vue v3.2.47 A change of types in core (vuejs/core#2818) introduced a TS compilation error when bumping to Vue v3.2.47. I couldn't figure out a proper way to fix, but using `EmitOptions` instead of `E` (which extends `EmitOptions`...) fixes the issue. It may be good enough to allow to update to the latest Vue releases, and I think it should have minimal impact on our users (or none at all). --------- Co-authored-by: renovate[bot] <29139614 renovate[bot]@users.noreply.github.com>
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
|
This change broke userland types that extends SetupContext. My code that type-checks emit signatures no longer works. I had this utility interface: And I was using it with event interface types to ensure emits were well type-checked. Is there a more official way of type-checking emits now? I'm using old style |
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like TypeScript does not evaluate type when it is in an object.
TS Playground
To fix #2362, I changed it using
T extends any ?.