Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue-carousel #818

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Add vue-carousel #818

merged 2 commits into from
Feb 23, 2017

Conversation

toddlawton
Copy link
Contributor

No description provided.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR :)
Can you update your commit according to the below guideline please ?

Always add your items to the end of a list. To be fair, the order is first-come-first-serve.

https://github.com/vuejs/awesome-vue/blob/master/CONTRIBUTING.md

@toddlawton
Copy link
Contributor Author

HI @kazupon I have updated the PR with vue-carousel at the bottom.

Thanks!

@kazupon kazupon merged commit a09f608 into vuejs:master Feb 23, 2017
@jasonkuhrt
Copy link

jasonkuhrt commented Feb 23, 2017

Always add your items to the end of a list. To be fair, the order is first-come-first-serve.

@kazupon If fairness is the issue then on account of vue-carousel-3d being an unattributed fork I think this should come before it. Also why are there libraries such as this one that are under the i18n section? Shouldn't these actually be under the components section?

@kazupon
Copy link
Member

kazupon commented Feb 23, 2017

@jasonkuhrt

If fairness is the issue then on account of vue-carousel-3d being an unattributed fork I think this should come before it

Unfortunately, In contribution guide, It is not strictly defined.
https://github.com/vuejs/awesome-vue/blob/master/CONTRIBUTING.md

I think so, forked repo should be come before un-forked repo.

In this issue, we are discussing due to awesome-vue have a some problem
#836

If you have an interested in it, you can join the it. 😉

Also why are there libraries such as this one that are under the i18n section? Shouldn't these actually be under the components section?

Yeah, you are right.
You can send Pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants