New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HumanPoseTransfer内のHumanPoseHandlerがDisposeされていない #2547

Open

mojopon opened this issue Dec 27, 2024 · 0 comments

Labels

bug

mojopon commented Dec 27, 2024 •

edited

Loading

環境情報

UniVRM version: 0.128.1
Unity version: Unity-2021.3.52f
OS: Windows 11

バグについて

HumanPoseTransfer.cs内で生成されるHumanPoseHandlerはIDisposableインターフェイスを備えており、使用後Disposeが必要
HumanPoseTransfer.cs内でのOn Enable時やSetPose/CreatePose時に生成されるHumanPoseHandlerがDisposeされていない
GameObjectのDeactivate/Activateが繰り返されると、On Enableが複数回呼ばれ、Disposeされないまま複数生成されたHumanPoseHandlerがパフォーマンスに悪影響を及ぼす（CPU負荷が高まっていく）

https://github.com/vrm-c/UniVRM/blob/master/Assets/UniGLTF/Runtime/UniHumanoid/HumanPoseTransfer.cs#L84
↑SetUpが複数回呼ばれるとHumanPoseHandlerがDisposeされないまま次のインスタンスが生成されてしまいます。

The text was updated successfully, but these errors were encountered:

mojopon added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment