Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support enum values with slash" #17

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

MJacred
Copy link
Contributor

@MJacred MJacred commented Jul 23, 2024

Reverts #15 - As far as I can tell, this PR fixes nothing

Fixes #16

@MJacred
Copy link
Contributor Author

MJacred commented Jul 24, 2024

@stephenafamo: could you kindly review?

@MJacred
Copy link
Contributor Author

MJacred commented Aug 16, 2024

@stephenafamo: ping for this and other PR

@stephenafamo stephenafamo merged commit b805427 into volatiletech:master Oct 23, 2024
@MJacred MJacred deleted the revert-15-enum_slash branch October 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #15 modified perfectly valid enum values: "/" replaced with "_"
2 participants