conky: fix maintainer mode #53852
Open
conky: fix maintainer mode #53852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just finished and merged conky#2132, which renames Remove Lastly, I added support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Comments
per last update - #52924
brndnmtthws/conky#2131
Void and nix both have
MAINTAINER_MODEon when it should not be. It is for conky"s own CI and turns onBUILD_TESTSwhen enabled.The new conky code does bomb with
BUILD_TESTSon andMAINTAINER_MODEoff. But Void disables checks for cross builds anyway, so it"s good enough to disable tests and maint-mode.This doesn"t really need rebuilt, just a better fix than previous fix.