-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support GNUInstallDirs #132
Comments
Will CMake properly detect both debug and release libs if cmake files are in separate directories? |
sorry can"t answer your question, because of lack of knowledge. |
I can send you the build log of the compilation on my linux Fedora 23 machine, maybe it |
This is helpful. Can you also provide spec file. I can add it to the repo. |
Of course, if I can help with it. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vlc-qt.spec hopefully you can add the libsuffix patch to your github |
I supported GNUInstallDirs. Please check if this works for you as expected. Otherwise I will just use your patch. |
i checked out your version from git.
[martin@fc23 SPECS]$ ll /home/martin/rpmbuild/BUILDROOT/vlc-qt-1.0.1-1.fc23.x86_64/usr/lib64/ /home/martin/rpmbuild/BUILDROOT/vlc-qt-1.0.1-1.fc23.x86_64/usr/lib/cmake/VLCQtCore: /home/martin/rpmbuild/BUILDROOT/vlc-qt-1.0.1-1.fc23.x86_64/usr/lib/cmake/VLCQtQml: /home/martin/rpmbuild/BUILDROOT/vlc-qt-1.0.1-1.fc23.x86_64/usr/lib/cmake/VLCQtWidgets: |
Just to make sure, did you build |
I think I"m wrong, i checked out: |
Interesting that it works for libraries but not for CMake files. I will add your original patch for now and leave this for later as it needs more investigation. |
Your patch should be in devel branch. If that"s OK for now, I"ll release 1.0.1 with it in today or tomorrow (as I will also be updating to VLC 2.2.2). |
That"s ok, many thanks for supporting me. |
@martinkg Could you please check the latest version |
i testet with the last git checkout, but the libraries are installed into /usr/lib, correct is /usr/lib64 RPM build errors: [martin@fc24 SPECS]$ ll /home/martin/rpmbuild/BUILDROOT/vlc-qt-1.1.0-0.1git98a0b9a.fc24.x86_64/usr/lib/ |
May it be related with this? It works for me in Ubuntu. |
@martinkg try one more time. It seems I need to include GNUInstallDirs after |
I managed to fix the spec. It builds for me on Fedora 24 and seems OK. I will merge this into 1.1.1 as it also fixes Ubuntu location. Please test, when you can.
Change files to:
Build with latest |
Add LIB_SUFFIX cmake convention to support fedora/redhat-style multilib, instead of hard-coding path
SET(VlcQtConfigPackageLocation lib/cmake/VLCQt)
Long-term, probably ought to consider using something like
https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html
instead
vlc-qt-1.0.0-libsuffix.patch.txt
The text was updated successfully, but these errors were encountered: