Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles traverser: do not check for visibility in canTraverse. (#3032) #3039

Open
wants to merge 2 commits into
base: 4.2-release
Choose a base branch
from

Conversation

Avnerus
Copy link
Collaborator

@Avnerus Avnerus commented Jun 27, 2024

Hi,
This is a version of PR #3032 for the 4.2-release branch.

@ibgreen
Copy link
Collaborator

ibgreen commented Jun 27, 2024

Make sure to check in the lock file. If you install locally and the lock file doesn't change you may want to install volta, which automatically configures yarn and node versions.

@Avnerus
Copy link
Collaborator Author

Avnerus commented Jun 27, 2024

Ah I see. It did change, but I thought I should not commit it to avoid unnecessary changes to the branch.
I'll add it then.

@Avnerus
Copy link
Collaborator Author

Avnerus commented Jun 27, 2024

The current failure happened to me locally as well but I was hoping it was only local.
I checked it earlier and this seems to be something that was fixed in master in the parquet module.

@ibgreen
Copy link
Collaborator

ibgreen commented Jun 27, 2024

The current failure happened to me locally as well but I was hoping it was only local. I checked it earlier and this seems to be something that was fixed in master in the parquet module.

Hmm yes, it looks like the 4.2-release branch may have experienced some "rot".

@Avnerus
Copy link
Collaborator Author

Avnerus commented Jun 28, 2024

The current failure happened to me locally as well but I was hoping it was only local. I checked it earlier and this seems to be something that was fixed in master in the parquet module.

Hmm yes, it looks like the 4.2-release branch may have experienced some "rot".

Would it be easier to merge this against 4.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants