Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix freeze on macos during big text paste #15087

Closed
wants to merge 1 commit into from
Closed

Fix freeze on macos during big text paste #15087

wants to merge 1 commit into from

Conversation

YuraAka
Copy link

@YuraAka YuraAka commented Jun 23, 2024

Environment

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Apr 13 2024 12:28:29)
macOS version - arm64
Included patches: 1-2136, 2142

Problem: When I paste more than 5890 chars text via Cmd V in insert mode vim freezes indefinitely.

Steps to reproduce:

  1. Run vim on new file
  2. Copy somewhere >5890 chars text
  3. Enter insert mode in vim
  4. Paste via Cmd V
  5. Find vim frozen and a console not responsible

P.S. Don't know how to write UT for such situation.

@chrisbra
Copy link
Member

I suppose this is on the terminal? What is end set to in your case? what is :set t_PE?

@YuraAka
Copy link
Author

YuraAka commented Jun 23, 2024

I suppose this is on the terminal? What is end set to in your case? what is :set t_PE?

Afaik, end is "\033[201~"

@chrisbra
Copy link
Member

And on what terminal? Does that terminal support bracketed paste?

@YuraAka
Copy link
Author

YuraAka commented Jun 23, 2024

And on what terminal? Does that terminal support bracketed paste?

I've tested on builtin macos Terminal.app and in iTerm2. Don't know about bracketed paste, how can I check it?

@chrisbra
Copy link
Member

I don't know. The manual of your terminal should know it. Does it work, if you :set t_PE= ?

@YuraAka
Copy link
Author

YuraAka commented Jun 25, 2024

I don't know. The manual of your terminal should know it. Does it work, if you :set t_PE= ?

Yes, it works, with additional '^[[201~' at the end.

@chrisbra
Copy link
Member

chrisbra commented Jul 4, 2024

Yes, it works, with additional '^[[201~' at the end.

That's strange. That indicates bracketed paste should actually work for you.

@chrisbra
Copy link
Member

chrisbra commented Nov 2, 2024

I don't think this patch is right. So I am not including this.

@chrisbra chrisbra closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuraAka @chrisbra