-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update menu translations for Japanese #10712
base: master
Are you sure you want to change the base?
Conversation
Could you explain what are these WIP PRs for? |
|
||
" Edit/Global Settings | ||
menutrans &Global\ Settings 全体設定(&G) | ||
menutrans Toggle\ Pattern\ &Highlight<Tab>:set\ hls! | ||
\ パターン強調切替(&H)<Tab>:set\ hls! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your script doesn't seem to handle line concatenation correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your script doesn't seem to handle line concatenation correctly.
Thanks. Yes, my script can't handle line concatenation. What about add the translations after line concatenation manually? It won't appear after applying this template.
runtime/lang/menu_ja_jp.utf-8.vim
Outdated
tmenu ToolBar.Cut クリップボードへ切り取り | ||
tmenu ToolBar.Copy クリップボードへコピー | ||
tmenu ToolBar.Paste クリップボードから貼り付け | ||
if !has("gui_athena") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gui_athena has been removed. So, this might not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gui_athena has been removed. So, this might not be needed.
Thanks, ok, I will remove it.
Codecov Report
@@ Coverage Diff @@
## master #10712 /- ##
==========================================
- Coverage 81.71% 81.71% -0.01%
==========================================
Files 158 158
Lines 185631 185631
Branches 41980 41979 -1
==========================================
- Hits 151684 151683 -1
- Misses 21485 21487 2
Partials 12462 12461 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
runtime/lang/menu_ja_jp.utf-8.vim
Outdated
" Menu Translations: Japanese (UTF-8) | ||
" Last Translator: MURAOKA Taro <[email protected]> | ||
" Last Change: 20-Feb-2022. | ||
" | ||
" Copyright (C) 2001-2022 MURAOKA Taro <[email protected]>, | ||
" vim-jp <http://vim-jp.org/> | ||
" Menu Translations: Japanese | ||
" Maintainer: Ada (Haowen) Yu <[email protected]> | ||
" Previous Maintainer: MURAOKA Taro <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the maintainer and copyright should not be changed in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the maintainer and copyright should not be changed in this PR.
Yes, you have a point there. How do you think copyrighted paragraph should be rewritten here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the maintainer and copyright should not be changed in this PR.
After applying this template, the previous maintainer may not recognize this file. It's hard for them to continue to maintain.
" menutrans BIND\ zone TRANSLATION\ MISSING | ||
" menutrans Blank TRANSLATION\ MISSING | ||
" menutrans C TRANSLATION\ MISSING | ||
" menutrans C TRANSLATION\ MISSING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should translate this. 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should translate this. 😃
All translations are optional. if translation is required, remove comments; If you think it's not necessary to translate this, leave it as it is. I'm going to clean it up with the regular expression on the last step.
Thank you very much for the advice. I've e-mailed Mr.Bram a few days ago, and he agreed. I've generated a fairly complete template for translating menu items for each language, and want to recruit volunteers to complete about the translation PR. These volunteers do not need to be proficient in Vim Script, but should know the language under the PR. I hope it will help. |
runtime/lang/menu_ja_jp.utf-8.vim
Outdated
menutrans &About Vimについて(&A) | ||
|
||
let g:menutrans_help_dialog = "ヘルプを検索したいコマンドもしくは単語を入力してください:\n\n挿入モードのコマンドには i_ を先頭に付加します. (例: i_CTRL-X)\nコマンドライン編集コマンドには c_ を先頭に付加します. (例: c_<Del>)\nオプションの名前には ' を付加します. (例: 'shiftwidth')" | ||
menutrans &Help ヘルプ(&H) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer using tab(s) instead of a space between the original message (i.e. "&Help" in this case) and the translated message ("ヘルプ(&H)" in this case).
Using only one space is hard to distinguish the original part and the translated part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've replace it. Also, I've add a new commit which have been modified according to your comments.
@chrisbra this is already translated |
Developers who know the language are now needed to help complete this PR. The menu translation items template is generated by https://github.com/adaext/vim-menutrans-helper. I've scanned all the menu items and created a fairly completed template. It haven't been updated for years, many new items would be added except items in
menu.vim
.