Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update menu translations for Japanese #10712

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

adaext
Copy link
Contributor

@adaext adaext commented Jul 12, 2022

Developers who know the language are now needed to help complete this PR. The menu translation items template is generated by https://github.com/adaext/vim-menutrans-helper. I've scanned all the menu items and created a fairly completed template. It haven't been updated for years, many new items would be added except items inmenu.vim.

@k-takata
Copy link
Member

Could you explain what are these WIP PRs for?
If you want to introduce a script for consistency of the translations, it might be better to be included in this repository.
I also think that it would be better to get agreement before creating a lot of WIP PRs.


" Edit/Global Settings
menutrans &Global\ Settings 全体設定(&G)
menutrans Toggle\ Pattern\ &Highlight<Tab>:set\ hls!
\ パターン強調切替(&H)<Tab>:set\ hls!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your script doesn't seem to handle line concatenation correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your script doesn't seem to handle line concatenation correctly.

Thanks. Yes, my script can't handle line concatenation. What about add the translations after line concatenation manually? It won't appear after applying this template.

tmenu ToolBar.Cut クリップボードへ切り取り
tmenu ToolBar.Copy クリップボードへコピー
tmenu ToolBar.Paste クリップボードから貼り付け
if !has("gui_athena")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gui_athena has been removed. So, this might not be needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gui_athena has been removed. So, this might not be needed.

Thanks, ok, I will remove it.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #10712 (49b4ad1) into master (99af91e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10712       /-   ##
==========================================
- Coverage   81.71%   81.71%   -0.01%     
==========================================
  Files         158      158              
  Lines      185631   185631              
  Branches    41980    41979       -1     
==========================================
- Hits       151684   151683       -1     
- Misses      21485    21487        2     
  Partials    12462    12461       -1     
Flag Coverage Δ
huge-clang-none 82.61% <ø> (ø)
linux 82.61% <ø> (ø)
mingw-x64-HUGE 0.00% <ø> (ø)
mingw-x64-HUGE-gui 78.16% <ø> (-0.01%) ⬇️
windows 76.94% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/if_xcmdsrv.c 76.07% <0.00%> (-0.18%) ⬇️
src/channel.c 83.83% <0.00%> (-0.18%) ⬇️
src/version.c 85.12% <0.00%> (ø)
src/regexp_nfa.c 90.01% <0.00%> (ø)
src/regexp_bt.c 87.36% <0.00%> ( 0.04%) ⬆️
src/gui.c 73.10% <0.00%> ( 0.04%) ⬆️
src/term.c 73.82% <0.00%> ( 0.05%) ⬆️
src/netbeans.c 72.81% <0.00%> ( 0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99af91e...49b4ad1. Read the comment docs.

" Menu Translations: Japanese (UTF-8)
" Last Translator: MURAOKA Taro <[email protected]>
" Last Change: 20-Feb-2022.
"
" Copyright (C) 2001-2022 MURAOKA Taro <[email protected]>,
" vim-jp <http://vim-jp.org/>
" Menu Translations: Japanese
" Maintainer: Ada (Haowen) Yu <[email protected]>
" Previous Maintainer: MURAOKA Taro <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the maintainer and copyright should not be changed in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the maintainer and copyright should not be changed in this PR.

Yes, you have a point there. How do you think copyrighted paragraph should be rewritten here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the maintainer and copyright should not be changed in this PR.

After applying this template, the previous maintainer may not recognize this file. It's hard for them to continue to maintain.

" menutrans BIND\ zone TRANSLATION\ MISSING
" menutrans Blank TRANSLATION\ MISSING
" menutrans C TRANSLATION\ MISSING
" menutrans C TRANSLATION\ MISSING
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should translate this. 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should translate this. 😃

All translations are optional. if translation is required, remove comments; If you think it's not necessary to translate this, leave it as it is. I'm going to clean it up with the regular expression on the last step.

@adaext
Copy link
Contributor Author

adaext commented Jul 12, 2022

Could you explain what are these WIP PRs for? If you want to introduce a script for consistency of the translations, it might be better to be included in this repository. I also think that it would be better to get agreement before creating a lot of WIP PRs.

Thank you very much for the advice. I've e-mailed Mr.Bram a few days ago, and he agreed. I've generated a fairly complete template for translating menu items for each language, and want to recruit volunteers to complete about the translation PR. These volunteers do not need to be proficient in Vim Script, but should know the language under the PR. I hope it will help.

menutrans &About Vimについて(&A)

let g:menutrans_help_dialog = "ヘルプを検索したいコマンドもしくは単語を入力してください:\n\n挿入モードのコマンドには i_ を先頭に付加します. (例: i_CTRL-X)\nコマンドライン編集コマンドには c_ を先頭に付加します. (例: c_<Del>)\nオプションの名前には ' を付加します. (例: 'shiftwidth')"
menutrans &Help ヘルプ(&H)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using tab(s) instead of a space between the original message (i.e. "&Help" in this case) and the translated message ("ヘルプ(&H)" in this case).
Using only one space is hard to distinguish the original part and the translated part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've replace it. Also, I've add a new commit which have been modified according to your comments.

@yegappan yegappan added this to the backlog milestone Aug 13, 2023
@ronin49
Copy link
Contributor

ronin49 commented May 1, 2024

@chrisbra this is already translated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants