Avoid serializing AuthInfo and input streams in RPC interfaces #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an input stream return type is used, this now produces a runtime error instead, until this is actually supported. AuthInfo arguments are never serialized and sent over the wire, as the code already intended.
s-ludwig
force-pushed
the
fix_spurious_rpc_serialization
branch
from
c21acec
to
5bfe84a
Compare
l-kramer
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an input stream return type is used, this now produces a runtime error instead, until this is actually supported. AuthInfo arguments are never serialized and sent over the wire, as the code already intended.