Fix meta would crash when balance in multiple relica #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
dangleptr,
laura-ding,
liuyu85cn,
bright-starry-sky and
panda-sheep
| @@ -106,10 106,6 @@ class Balancer { | |||
|
|
|||
| void finish() { | |||
| CHECK(!lock_.try_lock()); | |||
There was a problem hiding this comment.
A question，Is the useful now of lock?
There was a problem hiding this comment.
Yes, we need to make sure we hold the lock whenever we want to call finish
dangleptr
approved these changes
Feb 26, 2020
laura-ding
approved these changes
Feb 26, 2020
jude-zhu
pushed a commit
to jude-zhu/nebula
that referenced
this pull request
Mar 4, 2020
* fix meta would crash in multiple replica when build plan failed * add error log
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* fix meta would crash in multiple replica when build plan failed * add error log
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* Rename bijoin plan node * resolve the conflicts Co-authored-by: Yee <2520865 [email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1820