Fix size for database pools not being honored #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my, yes, that's it :) |
ioolkos
approved these changes
Oct 14, 2020
ioolkos
added a commit
that referenced
this pull request
Apr 10, 2021
* Update THANKS * Changing default: Don't make bridge direct_plugin_exports (subscribe,… (#1629) * Changing default: Don't make bridge direct_plugin_exports (subscribe, publish etc) wait for cluster readiness * Routing through QoS to internal PublishFun * Update changelog.md * Fix handling of WebSocket protocols (#1635) Correctly handles mutliple values in the `sec_websocket_protocol` HTTP header. * Update rebar.lock * Update rebar.config * Update changelog.md * Improve Proxy protocol error logging (#1637) * Adds usage information for vmq-admin retain command (#1) (#1639) * vmq-admin usage() includes retain command * Update changelog.md * Update vmq_diversity.schema * Update changelog.md * Update changelog.md * Fix size for database pools not being honored (#1657) * Ensure_that_MQTT_v5_user_properties_are_stored_to_disk/DB_#1560 (#1655) * Ensure_that_MQTT_v5_user_properties_are_stored_to_disk/DB_with_a_message_#1560 * relax p_msg_val_pre() type to allow properties to be persisted with payload Co-authored-by: ioolkos <[email protected]> * Fix RPC query * Add "m" shortcut for "more" * update certifi to 2.5.3 (#1685) * Allow configuration of buffer sizes for vmq_cluster_com, and autotune 'buffer' for vmq_cluster_node * no need for masking * Make Watermarks configurable for vmq_cluster_com listener * Update Hackney to 1.17.0 [dependency] * Update changelog.md * Webhooks HTTPS Enhancements Adds HTTPS-specific options to the webhooks module and tests. Allows users to specify a custom CA and verification options. Allows hooks to authenticate to endpoints with client certificates. Adds PEM validation to the vmq_server and vmq_webhooks schemas. * Updated clique dependency to fix trailing equal sign (Issue #1673) * Add missing server cert for webhooks test suite * Fix verify function Corrects the verify function to take the endpoint hostname. Sets reuse_sessions to false when verifying the peer certificate. * Add GitHub Actions * Update index.html Remove Slack * Webhooks HTTPS improvements (#1711) * Webhooks HTTPS improvements This adds CRL checking, which is enabled by default. It adds a number of tests to HTTPS Webhooks functionality, including: * fail if CRLs are required but not available * fail if the endpoint certificate is expired * fail if the endpoint certificate Common Name does not match hostname * Update index.html Remove Slack * Bump to trigger CI Co-authored-by: ioolkos <[email protected]> * Add macOS to CI (#1715) * Create ADOPTERS.md * Bump MongoDB driver to upstream with SRV (#1737) Bumps the MongoDB driver to latest upstream. Adds DNS SRV support to MongoDB in vmq_diversity. Add authentication to MongoDB test. Adds Docker Compose file for local testing. New CI profile to get tests with external services running in GitHub Actions. Bumps `rebar3` binary to latest. * Revert rebar3 (#1740) Reverts rebar3 to earlier version to fix broken release. Adds a smoke test in GitHub actions to detect broken releases in CI. * Update internal Luerl interface (luerl:do/1 is no more), update Luerl dependency (#1745) * Update changelog.md * upgrade to Cowboy 2.8.0 (#1747) * upgrade to Cowboy 2.8.0 * Add upgrade note to changelog. * Ignores the top-level data dir (#1749) * Support the MongoDB auth_source connect option (#1750) * Safe binary to term (#1752) * Validate UTF8 strings in topics and use safe binary_to_term. * Update changelog * update hackney to 1.17.4 (#1756) * fix ws options in proxy_protocol case (#1739) * fix ws options in proxy_protocol case * get peer info from proxy info * basic connect test for ws proxy protocol * add test for proxy protocol local command * Update changelog.md * Create FUNDING.yml * Update deps (#1772) * update hackney to 1.17.4 * pin rebar3_cuttlefish to commit tag * dialyzer Co-authored-by: Andrew Varner <[email protected]> Co-authored-by: Luke Dudney <32501671 [email protected]> Co-authored-by: Ruben Gees <[email protected]> Co-authored-by: Steve Lee <[email protected]> Co-authored-by: Drew Varner <[email protected]> Co-authored-by: wojciech.luczkow <[email protected]>
codeadict
pushed a commit
to codeadict/vernemq
that referenced
this pull request
Feb 4, 2022
* Update THANKS * Changing default: Don't make bridge direct_plugin_exports (subscribe,… (vernemq#1629) * Changing default: Don't make bridge direct_plugin_exports (subscribe, publish etc) wait for cluster readiness * Routing through QoS to internal PublishFun * Update changelog.md * Fix handling of WebSocket protocols (vernemq#1635) Correctly handles mutliple values in the `sec_websocket_protocol` HTTP header. * Update rebar.lock * Update rebar.config * Update changelog.md * Improve Proxy protocol error logging (vernemq#1637) * Adds usage information for vmq-admin retain command (#1) (vernemq#1639) * vmq-admin usage() includes retain command * Update changelog.md * Update vmq_diversity.schema * Update changelog.md * Update changelog.md * Fix size for database pools not being honored (vernemq#1657) * Ensure_that_MQTT_v5_user_properties_are_stored_to_disk/DB_#1560 (vernemq#1655) * Ensure_that_MQTT_v5_user_properties_are_stored_to_disk/DB_with_a_message_#1560 * relax p_msg_val_pre() type to allow properties to be persisted with payload Co-authored-by: ioolkos <[email protected]> * Fix RPC query * Add "m" shortcut for "more" * update certifi to 2.5.3 (vernemq#1685) * Allow configuration of buffer sizes for vmq_cluster_com, and autotune 'buffer' for vmq_cluster_node * no need for masking * Make Watermarks configurable for vmq_cluster_com listener * Update Hackney to 1.17.0 [dependency] * Update changelog.md * Webhooks HTTPS Enhancements Adds HTTPS-specific options to the webhooks module and tests. Allows users to specify a custom CA and verification options. Allows hooks to authenticate to endpoints with client certificates. Adds PEM validation to the vmq_server and vmq_webhooks schemas. * Updated clique dependency to fix trailing equal sign (Issue vernemq#1673) * Add missing server cert for webhooks test suite * Fix verify function Corrects the verify function to take the endpoint hostname. Sets reuse_sessions to false when verifying the peer certificate. * Add GitHub Actions * Update index.html Remove Slack * Webhooks HTTPS improvements (vernemq#1711) * Webhooks HTTPS improvements This adds CRL checking, which is enabled by default. It adds a number of tests to HTTPS Webhooks functionality, including: * fail if CRLs are required but not available * fail if the endpoint certificate is expired * fail if the endpoint certificate Common Name does not match hostname * Update index.html Remove Slack * Bump to trigger CI Co-authored-by: ioolkos <[email protected]> * Add macOS to CI (vernemq#1715) * Create ADOPTERS.md * Bump MongoDB driver to upstream with SRV (vernemq#1737) Bumps the MongoDB driver to latest upstream. Adds DNS SRV support to MongoDB in vmq_diversity. Add authentication to MongoDB test. Adds Docker Compose file for local testing. New CI profile to get tests with external services running in GitHub Actions. Bumps `rebar3` binary to latest. * Revert rebar3 (vernemq#1740) Reverts rebar3 to earlier version to fix broken release. Adds a smoke test in GitHub actions to detect broken releases in CI. * Update internal Luerl interface (luerl:do/1 is no more), update Luerl dependency (vernemq#1745) * Update changelog.md * upgrade to Cowboy 2.8.0 (vernemq#1747) * upgrade to Cowboy 2.8.0 * Add upgrade note to changelog. * Ignores the top-level data dir (vernemq#1749) * Support the MongoDB auth_source connect option (vernemq#1750) * Safe binary to term (vernemq#1752) * Validate UTF8 strings in topics and use safe binary_to_term. * Update changelog * update hackney to 1.17.4 (vernemq#1756) * fix ws options in proxy_protocol case (vernemq#1739) * fix ws options in proxy_protocol case * get peer info from proxy info * basic connect test for ws proxy protocol * add test for proxy protocol local command * Update changelog.md * Create FUNDING.yml * Update deps (vernemq#1772) * update hackney to 1.17.4 * pin rebar3_cuttlefish to commit tag * dialyzer Co-authored-by: Andrew Varner <[email protected]> Co-authored-by: Luke Dudney <32501671 [email protected]> Co-authored-by: Ruben Gees <[email protected]> Co-authored-by: Steve Lee <[email protected]> Co-authored-by: Drew Varner <[email protected]> Co-authored-by: wojciech.luczkow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: This is my first time with erlang.
Proposed Changes
This fixes the size option (
vmq_diversity.postgres.pool_sizeorDOCKER_VERNEMQ_VMQ_DIVERSITY__POSTGRES__POOL_SIZE) of all database pools to not be applied.Also changed the default to 5 like documented.
Types of Changes
Checklist
CODE_OF_CONDUCT.mddocumentI verified this works now by building a docker image from this branch and testing manually. I enabled postgres support, set the option to 1 and queried the database for connections with
SELECT * FROM pg_stat_activitywhich showed 1 connection. Also ran tests with./rebar3 eunitand./rebar3 ct.