Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: Modules with only 1 dependency show as having "Zero Dependencies!". #857

Closed
coolsp opened this issue Jul 27, 2018 · 6 comments
Closed

webui: Modules with only 1 dependency show as having "Zero Dependencies!". #857

coolsp opened this issue Jul 27, 2018 · 6 comments
Assignees
@ayusharma
Labels
issue: bug outdated
Milestone
3.x

Comments

@coolsp
Copy link
Member

coolsp commented Jul 27, 2018 •
edited by juanpicado
Loading

With v3.3.0, using webui, a module with only 1 dependency shows "Zero Dependencies!" instead of showing the actual dependency.

Steps to reproduce the behavior:

  1. Publish a module like 'debug' (which only has 1 dependency)
  2. Check using the webui
  3. It will display "Zero Dependencies!" in the right-pane, should show 'ms'.

To solve, check file:
verdaccio/src/webui/components/PackageSidebar/modules/Dependencies/index.jsx

Line 33:
 {dependenciesList.length > 1 ? (
should be
 {dependenciesList.length > 0 ? (

;-)
@ayusharma ayusharma self-assigned this Jul 27, 2018
@ayusharma
Copy link
Member

It's confirmed. @coolsp would you like to send a PR for this OR should I pick up this one?

@coolsp
Copy link
Member Author

coolsp commented Jul 27, 2018

If you can, would be great.
Thanks !!!

@juanpicado juanpicado added this to the 3.x.x milestone Jul 27, 2018
ayusharma added a commit that referenced this issue Jul 27, 2018
@ayusharma
fix: solves dependency bug for one dependency (#857)
f9c9c44
juanpicado added a commit that referenced this issue Jul 27, 2018
@juanpicado
Merge branch 'master' into #857-deps-bug
943ddeb
@ayusharma ayusharma mentioned this issue Jul 27, 2018
Merged
juanpicado added a commit that referenced this issue Jul 27, 2018
@juanpicado
Merge pull request #860 from verdaccio/#857-deps-bug
ce1f7a9 
fix: solves dependency bug for one dependency (#857)
@juanpicado
Copy link
Member

Shipped on latest: 3.4.1

@ayusharma
Copy link
Member

@coolsp Thanks for reporting this.

@coolsp
Copy link
Member Author

coolsp commented Jul 28, 2018

Tested using Docker image verdaccio/verdaccio:latest (v3.4.1) and confirm this is fixed.
Thanks @ayusharma @juanpicado what a quick turnaround, impressive !

juanpicado added a commit that referenced this issue Jul 28, 2018
@juanpicado
chore: add unit test for #857 scenario
b0b631a
@juanpicado juanpicado mentioned this issue Jul 28, 2018
Merged
juanpicado added a commit that referenced this issue Jul 28, 2018
@juanpicado
Merge pull request #861 from verdaccio/fix-857-test
e4bf71a 
chore: add unit test for #857 scenario
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@ayusharma @paulbrimicombe
fix: solves dependency bug for one dependency (verdaccio#857)
b3d049a
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@juanpicado @paulbrimicombe
chore: add unit test for verdaccio#857 scenario
4731530
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@ayusharma @paulbrimicombe
fix: solves dependency bug for one dependency (verdaccio#857)
d4b6458
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@juanpicado @paulbrimicombe
chore: add unit test for verdaccio#857 scenario
4bd88e8
ayusharma added a commit to ayusharma/verdaccio that referenced this issue Dec 7, 2018
@ayusharma
fix: solves dependency bug for one dependency (verdaccio#857)
a704168
@lock
Copy link

lock bot commented Feb 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Feb 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayusharma ayusharma

Labels
issue: bug outdated
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
3 participants
@juanpicado @coolsp @ayusharma