Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): use default prettier for examples/templates #60530

Merged
merged 1 commit into from
Jan 11, 2024
Merged

chore(examples): use default prettier for examples/templates #60530

merged 1 commit into from
Jan 11, 2024

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 11, 2024 •
edited
Loading

Description

This PR ensures that the default prettier config is used for examples and templates.

This config is compatible with prettier@3 as well (upgrading prettier is bigger change that can be a future PR).

Changes

  • Updated .prettierrc.json in root with "trailingComma": "es5" (will be needed upgrading to prettier@3)
  • Added examples/.prettierrc.json with default config (this will change every example)
  • Added packages/create-next-app/templates/.prettierrc.json with default config (this will change every template)

Related

@styfle styfle requested review from StephDietz and removed request for a team January 11, 2024 17:22
@styfle styfle changed the title [examples] use default prettier for examples/templates chore(examples): use default prettier for examples/templates Jan 11, 2024
@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples Font (next/font) Related to Next.js Font Optimization. area: tests Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Jan 11, 2024
@ijjk
Copy link
Member

ijjk commented Jan 11, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
buildDuration 12.9s 13s N/A
buildDurationCached 7s 6.2s N/A
nodeModulesSize 200 MB 200 MB ✓
nextStartRea..uration (ms) 424ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
433-HASH.js gzip 28.6 kB 28.6 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.2 kB 45.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB ✓
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.4 kB 3.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
index.html gzip 529 B 528 B N/A
link.html gzip 540 B 540 B ✓
withRouter.html gzip 524 B 523 B N/A
Overall change 540 B 540 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js fix-prettier-examples-templates Change
app-page-exp...dev.js gzip 169 kB 169 kB ✓
app-page-exp..prod.js gzip 95.2 kB 95.2 kB ✓
app-page-tur..prod.js gzip 95.9 kB 95.9 kB ✓
app-page-tur..prod.js gzip 90.5 kB 90.5 kB ✓
app-page.run...dev.js gzip 142 kB 142 kB ✓
app-page.run..prod.js gzip 89.8 kB 89.8 kB ✓
app-route-ex...dev.js gzip 24.1 kB 24.1 kB ✓
app-route-ex..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.3 kB 16.3 kB ✓
app-route.ru...dev.js gzip 23.5 kB 23.5 kB ✓
app-route.ru..prod.js gzip 16.3 kB 16.3 kB ✓
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB ✓
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.6 kB 49.6 kB ✓
Overall change 940 kB 940 kB ✓
Commit: fbd83b3

@ijjk
Copy link
Member

ijjk commented Jan 11, 2024 •
edited
Loading

Tests Passed

@styfle styfle force-pushed the fix-prettier-examples-templates branch from b938600 to fbd83b3 Compare January 11, 2024 20:46
@styfle styfle enabled auto-merge (squash) January 11, 2024 22:58
@styfle styfle merged commit 4466ba4 into canary Jan 11, 2024
69 checks passed
@styfle styfle deleted the fix-prettier-examples-templates branch January 11, 2024 23:01
@vordgi vordgi mentioned this pull request Jan 21, 2024
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wyattjoh wyattjoh wyattjoh approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@leerob leerob Awaiting requested review from leerob

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples Font (next/font) Related to Next.js Font Optimization. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

style: formatting in new Next.js apps deviate from prettier defaults
3 participants
@styfle @ijjk @wyattjoh