Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nonce attribute for inline script if provided #3129

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

dstaley
Copy link
Contributor

@dstaley dstaley commented Oct 18, 2017

In locked-down CSP environments, the use of inline scripts is considered a CSP violation. In order to use inline scripts without triggering a CSP violation, you can provide a nonce attribute on the script tag. This PR allows users to pass in a nonce value as a prop on NextScript, which will allow the script to execute without the use of the unsafe-inline CSP directive.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants