Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-hot-loader & warnings #3110

Merged
merged 1 commit into from
Oct 16, 2017
Merged

react-hot-loader & warnings #3110

merged 1 commit into from
Oct 16, 2017

Conversation

oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Oct 16, 2017

Proof of concept to close #3109
We might also need to update the dependency.

@timneutkens
Copy link
Member

For reference: gaearon/react-hot-loader#666 (comment)

It is new in v3, it gives you warning about component not accepted by React Hot Loader. The behaviour is the same as v3.0.0-beta.7 except you don’t get any warning about not accepted components.

@timneutkens timneutkens merged commit 180cd9f into vercel:master Oct 16, 2017
@timneutkens
Copy link
Member

Thanks Olivier, i'm going to take this in and pin react-hot-loader.

@oliviertassinari oliviertassinari deleted the patch-1 branch October 16, 2017 19:44
@oliviertassinari
Copy link
Contributor Author

@neoziro Would you say it's the best path going forward? I'm not sure the warnings are actionable on next.js side

@gregberge
Copy link

@oliviertassinari yes I think it is better to disable them

@timneutkens
Copy link
Member

Thanks for confirming @neoziro

@nathanqueija
Copy link

How can I disable these warnings? I am gettin 20k > warnings and chrome crashes because of memory leak.

@timneutkens
Copy link
Member

@nathanqueija I'll make sure we do a release today with this fix

@nathanqueija
Copy link

Ok @timneutkens
Thanks, man!

@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants