Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with pkg example #2751

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Add with pkg example #2751

merged 1 commit into from
Aug 10, 2017

Conversation

sergiodxa
Copy link
Contributor

Example using pkg to create a binary of a Next.js app.

@sergiodxa sergiodxa added the examples Issue was opened via the examples template. label Aug 10, 2017
@sergiodxa sergiodxa requested a review from timneutkens August 10, 2017 05:11
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@timneutkens timneutkens merged commit cc5289a into vercel:master Aug 10, 2017
timneutkens pushed a commit to timneutkens/next.js that referenced this pull request Aug 19, 2017
timneutkens added a commit that referenced this pull request Aug 27, 2017
* Add examples/with-redux-code-splitting. (#2721)

* #1757 Relay Modern Example (#2696)

* Add ReasonML example (#2640)

* Add ReasonML example

* Add a gitignore specifically for the reasonml example

* Allow custom className for <Main /> (#2802)

* 3.0.2

* Remove beta information from the README.

* 3.0.3

* Remove unnecessary lookup in example with emotion (#2731)

* Document SCSS/Less (#2742)

* Document SCSS/Less

* Add missing word

* Add docs for examples dir

* Add extra example

* uppercase J

* Add with pkg example (#2751)

* Add custom server micro example (#2750)

* Ease running multiple examples at the same time with process.env.PORT (#2753)

* Add line-height rule for error page h2 (#2761)

* Add support for fetching multiple translation files (#2743)

* Add support for fetching multiple translation files

* Cleanup

* Clear missed interval (#2611)

* clear missed interval

* remove trailing whitespace

* Relay Modern Example (#1757) (#2773)

* Simplification of Relay Modern Example (#1757) (#2776)

* Use deterministic names for dynamic import (#2788)

* Always use the same name for the same dynamic import.

* Add unit tests for the modulePath generation.

* Allow tests to run correctly on Windows.

* Make the chunk name a bit pretty.

* Fix tests to run on Windows.

* 3.0.4

* Revert "Make the chunk name a bit pretty." (#2792)

This reverts commit 0c9e8cf.

* 3.0.5

* Use _ as the divider for dynamic import name splitter. (#2793)

Using - gives us some weird webpack errors.

* 3.0.6

* next/dynamic Error Message Tweaks (#2798)

* Fixed issue (#2804)

#2800

* docs(material-ui): move the source code to Material-UI repository (#2808)
@winneon
Copy link

winneon commented Sep 2, 2017

This example does not work if you move the generated binary anywhere else. Because of this, you cannot distribute said binary. How would I go about fixing this?

To be more specific, the error you get when moving the executable is as follows:

> Could not find a valid build in the '.next' directory! Try building your app with 'next build' before starting the server.

@evenchange4
Copy link
Contributor

@winneon I create a PR #4307 for this issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants