Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NPM modules out of the commons chunk in dev mode. #2716

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Move NPM modules out of the commons chunk in dev mode. #2716

merged 1 commit into from
Aug 7, 2017

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Aug 7, 2017

This is only a dev feature and it removes an error in HMR.
Otherwise it'll throw an error with undefined error in the webpack core.

@arunoda
Move NPM modules out of the commons chunk in dev mode.
551b6cf 
This is only a dev feature and it removes an error in HMR.
Otherwise it'll throw an error with undefined error in the webpack core.
timneutkens
timneutkens approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arunoda arunoda merged commit 6477492 into vercel:v3-beta Aug 7, 2017
@arunoda arunoda deleted the move-npm-modules-to-pages branch August 7, 2017 07:06
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunoda @timneutkens