New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack's ModuleConcatenationPlugin plugin doesn't work well with HMR. #2584

Merged

arunoda merged 1 commit into vercel:v3-beta from arunoda:use-module-contact-webpack-plugin-in-prod-only

Jul 17, 2017

Contributor

arunoda commented Jul 17, 2017 •

edited

Loading

So, now we only use it for production.
This is how we can re-produce this error: https://github.com/arunoda/webpack-module-concat-hmr-issues

May be related: webpack/webpack#3627


          Webpack's ModuleConcatenationPlugin plugin doesn't work well with HMR.

4e07383

So, now we only use it for production.

arunoda merged commit d831e6d into vercel:v3-beta

arunoda deleted the use-module-contact-webpack-plugin-in-prod-only branch

July 17, 2017 16:46

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet