Component display name fixes for Apollo examples #2211
Merged
12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just implemented the same function as used in the core: #2286. After travis is done building I'll merge 👍 |
|
@timneutkens that other implementation came later than this PR but for some reason didn't factor in anonymous functions and won't result in the anonymous stateless page component "after" screenshot. In the inspector it would look like |
|
Just tested this. It works as expected 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Apollo examples, the
displayNameof thewidthDatadecorated component breaks when using anonymous or named stateless components.Before
Anonymous stateless page component:
Named stateless page component:
After
Anonymous stateless page component:
Named stateless page component: