Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug error colors #2182

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Update debug error colors #2182

merged 3 commits into from
Jun 9, 2017

Conversation

chrispuska
Copy link

Replaces the current error-debug bright fuschia colors with darker, more readable colors. #2100

next-error-colors

@timneutkens
Copy link
Member

Cool!

@arunoda arunoda changed the base branch from v3-beta to master June 7, 2017 08:30
@arunoda arunoda changed the base branch from master to v3-beta June 7, 2017 08:31
@arunoda
Copy link
Contributor

arunoda commented Jun 7, 2017

I'd like to have these changes:

diff --git a/lib/error-debug.js b/lib/error-debug.js
index 0d065e3..298dacd 100644
--- a/lib/error-debug.js
    b/lib/error-debug.js
@@ -43,7  43,7 @@ const styles = {
     fontFamily: '"SF Mono", "Roboto Mono", "Fira Mono", consolas, menlo-regular, monospace',
     fontSize: '13px',
     lineHeight: '18px',
-    color: '#6F6767',
     color: '#8b8b8b',
     margin: 0,
     whiteSpace: 'pre-wrap',
     wordWrap: 'break-word',
@@ -53,9  53,9 @@ const styles = {
   heading: {
     fontFamily: '-apple-system, system-ui, BlinkMacSystemFont, Roboto, "Segoe UI", "Fira Sans", Avenir, "Helvetica Neue", "Lucida Grande", sans-serif',
     fontSize: '20px',
-    fontWeight: 'bold',
     fontWeight: '400',
     lineHeight: '28px',
-    color: '#ebe7e5',
     color: '#ff85af',
     marginBottom: '0px',
     marginTop: '0px'
   }

screen shot 2017-06-07 at 2 25 49 pm

Update it (with your changes) and let me know. I'll take this.

@chrispuska
Copy link
Author

@arunoda Fine by me, it's better with a lighter first line. Changed your colors slightly to match with my initial background.

screenshot 2017-06-07 11 29 29

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool 👌
cc @evilrabbit could you take a peek to confirm 😄

@evilrabbit
Copy link
Member

evilrabbit commented Jun 8, 2017

Guys maybe we should try our red for the title: #FF001F or white. I don't like the "pink".
But I really like the 'theme'!

@chrispuska
Copy link
Author

@evilrabbit Red or white header? I prefer the white, more readable, the screen itself already indicates that you have an error.

zeit-red

@timneutkens
Copy link
Member

IMO the white header. But lets wait for evilrabbit.

@arunoda
Copy link
Contributor

arunoda commented Jun 9, 2017

Pure red is basically hard for the eyes. That's why I went for pink.
Anyway, I'm fine with white color with font-weight: 400 for the heading.

@arunoda
Copy link
Contributor

arunoda commented Jun 9, 2017

This is great.
Let's take this in.

@arunoda arunoda merged commit 28b40a5 into vercel:v3-beta Jun 9, 2017
@timneutkens
Copy link
Member

Amazing work! 😍

@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants