-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update debug error colors #2182
Conversation
Cool! |
I'd like to have these changes: diff --git a/lib/error-debug.js b/lib/error-debug.js
index 0d065e3..298dacd 100644
--- a/lib/error-debug.js
b/lib/error-debug.js
@@ -43,7 43,7 @@ const styles = {
fontFamily: '"SF Mono", "Roboto Mono", "Fira Mono", consolas, menlo-regular, monospace',
fontSize: '13px',
lineHeight: '18px',
- color: '#6F6767',
color: '#8b8b8b',
margin: 0,
whiteSpace: 'pre-wrap',
wordWrap: 'break-word',
@@ -53,9 53,9 @@ const styles = {
heading: {
fontFamily: '-apple-system, system-ui, BlinkMacSystemFont, Roboto, "Segoe UI", "Fira Sans", Avenir, "Helvetica Neue", "Lucida Grande", sans-serif',
fontSize: '20px',
- fontWeight: 'bold',
fontWeight: '400',
lineHeight: '28px',
- color: '#ebe7e5',
color: '#ff85af',
marginBottom: '0px',
marginTop: '0px'
} Update it (with your changes) and let me know. I'll take this. |
@arunoda Fine by me, it's better with a lighter first line. Changed your colors slightly to match with my initial background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks cool 👌
cc @evilrabbit could you take a peek to confirm 😄
Guys maybe we should try our red for the title: #FF001F or white. I don't like the "pink". |
@evilrabbit Red or white header? I prefer the white, more readable, the screen itself already indicates that you have an error. |
IMO the white header. But lets wait for evilrabbit. |
Pure red is basically hard for the eyes. That's why I went for pink. |
This is great. |
Amazing work! 😍 |
Replaces the current error-debug bright fuschia colors with darker, more readable colors. #2100