Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -apply-system font on error page #140

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Use -apply-system font on error page #140

merged 1 commit into from
Oct 28, 2016

Conversation

wolverian
Copy link
Contributor

The CSS rule on the error page doesn"t work and the text on the page isn"t rendered in SF UI Text. If we want to use SF on the error page, then, at least in Safari, we can use -apply-system as the font family.

I also added a fallback to sans-serif, just to be explicit.

@wolverian
Use -apply-system font on error page
e226dd8 
The CSS rule on the error page doesn"t work and the text on the page isn"t rendered in SF UI Text. If we want to use SF on the error page, then, at least in Safari, we can use `-apply-system` as the font family.

I also added a fallback to sans-serif, just to be explicit.
@rauchg rauchg merged commit c69686b into vercel:master Oct 28, 2016
@rauchg
Copy link
Member

rauchg commented Oct 28, 2016

Perfect. Thank you!

@colepeters colepeters mentioned this pull request Oct 29, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolverian @rauchg