Ensure NODE_ENV is production when deploying on Now #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
both will default to production: It's also been taken in account on the custom-server example: So I'm thinking we should improve the custom server section of the readme instead of this one 🤔 |
|
Sure, I updated 👍 |
timneutkens
reviewed
Feb 13, 2017
README.md
Outdated
| @@ -445,6 445,8 @@ Supported options: | |||
| - `dir` (`string`) where the Next project is located - default `'.'` | |||
| - `quiet` (`bool`) Hide error messages containing server information - default `false` | |||
|
|
|||
| Then, change your `build` script to `NODE_ENV=production node server.js`. | |||
There was a problem hiding this comment.
It's the start script right?
There was a problem hiding this comment.
Since you still have to next build when using the custom server.
https://github.com/zeit/next.js/blob/master/examples/custom-server/package.json#L5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @matheuss pointed out in the #now Slack channel, NODE_ENV should probably be set explicitly for deploying on Now.
This example code uses
next buildwhich implicitly doesn't create a dev server (AFAIK), so it works as it is, but it gives the impression that you could just switch"build": "next build"with"build": "node server.js"when going for a custom server. But probably (based on the example in same README), you'll declare the server asconst app = next({ dev: process.env.NODE_ENV !== 'production' });, meaning that unless NODE_ENV is explicitly set, the deployment will fail (becausedevwill betrue, and thus will try to write to the.nextdirectory which isn't writable on Now (EACCES: permission denied, rmdir '/home/nowuser/src/.next').So I thought it'd be better to educate people that they should set NODE_ENV somehow.