-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add global stylesheet example #1016
Conversation
Hey @davibe , thanks for the example. Just today I was looking to add an external CSS file. I got it working with After a quick look into your example I noticed a couple things:
|
|
You're all doing such awesome work 💖 |
@@ -0,0 1,2 @@ | |||
.next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other examples include a .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not hurt but i'll remove it
@@ -0,0 1,31 @@ | |||
README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you port this documentation to the same style as https://github.com/zeit/next.js/tree/master/examples/basic-css. All examples have kind of the same readme ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the 2 points I had this looks great, it's a port of your github repo right 👍
Yes. I would like to keep it in sync with the repo because i can track issues there and sync-back from time to time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@@ -0,0 1,687 @@ | |||
<img width="112" alt="screen shot 2016-10-25 at 2 37 27 pm" src="https://cloud.githubusercontent.com/assets/13041/19686250/971bf7f8-9ac0-11e6-975c-188defd82df1.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @davibe seems like you included the main repo readme 😅 I meant include this one but updated to your example 👍
https://raw.githubusercontent.com/zeit/next.js/master/examples/basic-css/README.md
I know "global" styles are not a priority for 2.0 release but i think this example really solves it for many users in the mean time.
Fixes #544