Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISG with GIP in _app overrides cache-control of ISG page #14244

Open
Timer opened this issue Jun 16, 2020 · 2 comments
Open

ISG with GIP in _app overrides cache-control of ISG page #14244

Timer opened this issue Jun 16, 2020 · 2 comments
Assignees
@lfades
Labels
good first issue Easy to fix issues, good for newcomers Pages Router Related to Pages Router. type: next
Milestone
backlog

Comments

@Timer
Copy link
Member

Timer commented Jun 16, 2020

Bug report

When using the unstable_revalidate param with ISG, a header set by _app should never win.

Additional context

From @lfades:

Update: this is currently not the case, SSG finishes the request before it gets to _app.

the custom _app in the Next.js site was setting a header, but that causes an error because the request was sent, this happens in production and with next start, but in dev you don't get any error.
@Timer Timer added this to the 9.x.x milestone Jun 16, 2020
@Timer
Copy link
Member Author

Timer commented Jun 16, 2020

@lfades re-assigned you from internal tracker. Let me know if this is a non-issue anymore!

@lfades
Copy link
Member

lfades commented Nov 7, 2020

Here's a reproduction for the bug: https://github.com/lfades/next-issue-14244. You can test it by running yarn build && yarn start and then refreshing the index page.

Very minor issue as no one has been running into it but any PRs to fix it are welcome!

@lfades lfades added good first issue Easy to fix issues, good for newcomers type: next labels Nov 7, 2020
@Timer Timer modified the milestones: 10.x.x, backlog Jan 22, 2021
@balazsorban44 balazsorban44 added Pages Router Related to Pages Router. and removed area: Static Generation labels Apr 17, 2024
@samcx samcx removed the kind: bug label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfades lfades

Labels
good first issue Easy to fix issues, good for newcomers Pages Router Related to Pages Router. type: next
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
5 participants
@Timer @lfades @timneutkens @balazsorban44 @samcx