Skip to content

Commit

Permalink
docs(turbopack): Document build dependency on clang for rocksdb (#72493)
Browse files Browse the repository at this point in the history
Noticed this after rebuilding on top of #71688 

Most Linux distributions default to `gcc` for their default `cc`
implementation (e.g. via Debian's `build-essential` meta-package, which
we can probably implicitly assume is installed), which means that they
won't typically have `clang` installed.

`librocksdb-sys` seems to always depend on `clang` on Linux. It looks
like this might be a consequence of using
[rust-bindgen](https://github.com/rust-lang/rust-bindgen) (though I'm
confused why this didn't come up earlier), as it looks like rocksdb can
otherwise build with gcc.

This shouldn't be an issue for macos, since `clang` is the default `cc`
on that platform.
  • Loading branch information
bgw authored Nov 18, 2024
1 parent f72dc6a commit 7e9e18b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions contributing/core/developing.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 12,9 @@
```
corepack enable pnpm
```
- (Linux) Install LLD, the LLVM linker:
- (Linux) Install LLD (the LLVM linker) and Clang (used by `rust-rocksdb`):
```
sudo apt install lld
sudo apt install lld clang
```

## Local Development
Expand Down

0 comments on commit 7e9e18b

Please sign in to comment.