Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to [email protected] to fix minfy with negated in statements #1194

Closed
wants to merge 1 commit into from

Conversation

byCedric
Copy link

@byCedric byCedric commented Jun 4, 2024

Fixes #1193

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byCedric
Copy link
Author

byCedric commented Jun 6, 2024

These are interesting failures, I'm not sure why Node 20 on Ubuntu causes that error, while Node 20 on Windows seems fine.

The MacOS errors are just node-gyp (install) related issues, likely due to the GHA runner missing some low-level dependency. It's also erroring on node-canvas which isn't touched in this PR.

Edit: yeah, the macos failures are definitely related to missing system dependencies:

image

@byCedric
Copy link
Author

byCedric commented Jun 6, 2024

Also interesting here is that the last run on workflow (4 months ago) did not succeed for Node 20 on Ubuntu (this run). Unfortunately, the logs have been wiped already, but that might be a pointer to this failure too.

I'm also guessing the macos-latest runner has been changed within 4 months, causing the CI failures.

@styfle
Copy link
Member

styfle commented Jun 7, 2024

I see what you mean. I'll run CI against main to see how it compares:

@byCedric
Copy link
Author

byCedric commented Jun 8, 2024

Glad you could repro this on main (as in, not caused by this PR) 😄

Anything I can do to help?

@styfle
Copy link
Member

styfle commented Jun 10, 2024

I think we need to fix main before merging this to confirm it works as expected

@theoludwig
Copy link
Contributor

I think we need to fix main before merging this to confirm it works as expected

What was the problem with CI (the logs disappeared)? Should probably run CI again, with all the depdencies updated to their latest version, to see the status of the project.

@styfle
Copy link
Member

styfle commented Sep 10, 2024

@theoludwig Feel free to create a new PR to fix it

@theoludwig
Copy link
Contributor

@theoludwig Feel free to create a new PR to fix it

Alright. 😄 #1213

Tests are working locally, but about CI, I don't know, need an approval to run it. Hopefully, it fixes the issue, and allow to update terser and webpack to latest version to get latest fixes like this one with negated in statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Terser causes a syntax issue when minify-ing code
3 participants