Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cose-spec from draft to RFC 9052 #109

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Update cose-spec from draft to RFC 9052 #109

merged 1 commit into from
Oct 7, 2022

Conversation

fxamacker
Copy link
Contributor

@fxamacker fxamacker mentioned this pull request Oct 2, 2022
Closed
@thomas-fossati
Copy link
Contributor

thomas-fossati commented Oct 4, 2022 •
edited
Loading

Thanks very much @fxamacker

Could you please fix the failing DCO check so that we can merge, please?

@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #109 (1fd96e9) into main (4e80cfa) will increase coverage by 0.30%.
The diff coverage is n/a.

❗ Current head 1fd96e9 differs from pull request most recent head 59622d7. Consider uploading reports for the commit 59622d7 to get more accurate results

@@            Coverage Diff             @@
##             main     #109       /-   ##
==========================================
  Coverage   91.79%   92.10%    0.30%     
==========================================
  Files          10       10              
  Lines         975      975              
==========================================
  Hits          895      898        3     
  Misses         54       51       -3     
  Partials       26       26
Impacted Files Coverage Δ
headers.go 93.05% <0.00%> ( 0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

thomas-fossati
thomas-fossati approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

SteveLasker
SteveLasker approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great progress

@SteveLasker SteveLasker merged commit ac30917 into veraison:main Oct 7, 2022
@SteveLasker
Copy link
Contributor

Thanks @fxamacker, and welcome to the go-cose family

@SteveLasker SteveLasker mentioned this pull request Nov 2, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roywill roywill roywill approved these changes

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cose-spec from draft to RFC 9052
4 participants
@fxamacker @thomas-fossati @SteveLasker @roywill