Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of Aug 14, 2022 the creator of
tui-rs
announced he was stepping back from the project and has since archived the repository. ratatui has emerged as the successor library and has demonstrated a year of solid development.I apologize for not opening a feature issue first. I wrote the update to use for my own purposes before considering contributing my changes upstream. No hard feelings if you choose to close this PR.
List here your changes
with-<backend>
feature flags to generalize them across the new high level TUI library options. I suggest deprecating thewith-
feature flags in favor of explicitly naming each component feature individually (eg.--features ratatui,crossterm,derive
). See the README changes for more details. I may have to update the README here depending on your feedback.Maintainability notes
I have listed this as a breaking change in the questionnaire below. As written this should not actually be a breaking change for tui-realm users, it is strictly an enhancement allowing the use of the currently maintained
tui-rs
alternative. As the project owner I urge you to consider issuing a breaking change to switch the default TUI library toratatui
(and potentially droptui-rs
support).Testing and CI notes
To effectively check the changes introduced by this PR you have to run the test suite with the cross product of backends and TUI libraries supported. The following
cargo test
commands are passing and should be added to the CI:cargo test --features tui,crossterm,derive --no-default-features
cargo test --features tui,termion,derive --no-default-features
cargo test --features ratatui,crossterm,derive --no-default-features
cargo test --features ratatui,termion,derive --no-default-features
Type of change
Please select relevant options.
Checklist
cargo fmt
cargo clippy
and reports no warningscfg target_os
)