-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support to GCP #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Patching the front-end for GCP (WIP) - Add Attack Technique: GCP - Establishes Access as Service Account (WIP
Merge main with dev/gcp
- Create GCP Access Manager class - Improve technique for GCP establish access for SA
…ame and description - Fix bug on source of history for GCP attack surface - Seperate method for refresh the token of credential - Improve the attack technique name and description for "GCPEstablishAccessAsServiceAccount" technique
…or GCPEstablishAccessAsServiceAccount technique - Add capability for GCP Access Manager to save credential to a JSON file in form base64 for sensitive info - Add option to save credential and change info output for success attack from 'email' to 'email/client_id' of GCPEstablishAccessAsServiceAccount
- Improve several method on GCPAccess class to handle credential - Add ability to choose credential (WIP)
Hi @openrec0n, can you add "WIP" label on this PR? |
openrec0n
added
enhancement
New feature or request
new technique
A new technique is added to Halberd
wip
A work in progress. Help or additional review needed
labels
Nov 20, 2024
- Updated the GCP credentials icon to replace AWS icon with a GCP-specific icon, improving scope and project ID representation. - Added functionality to delete the current/selected GCP credential via a new callback. - Fixed the delete_current_credentials method in GCPAccess to ensure only the current/selected credential is deleted and saved, while preserving undeleted credentials.
Hi @openrec0n, you can review the PR |
Closed
@jesayafn thanks for the PR. I am reviewing this |
openrec0n
requested changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesayafn Please check the comments and implement the suggested changes.
… clean up code - Correct typo in callback C062 description. - Improve execution output for the GCPEstablishAccessAsServiceAccount technique. - Remove unnecessary code, lines, and comments. - Fix a typo in a comment.
openrec0n
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
new technique
A new technique is added to Halberd
wip
A work in progress. Help or additional review needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Support to GCP
Related issue: #30
Feature enhancement: