fix: sort by with types

varianter · mikaelbr · Oct 18, 2022 · Jan 4, 2022 · Jan 5, 2022 · Jan 7, 2022
commit 87298c441e749a08df11c05d1959a18e856743c3
diff --git a/package.json b/package.json
@@ -37,10  37,10 @@
     "@mdx-js/loader": "^2.0.0-rc.2",
     "@mdx-js/mdx": "2.0.0-next.9",
     "@mdx-js/react": "^2.0.0-rc.2",
     "@pabra/sortby": "^1.0.2",
     "@variant/profile": "^3.0.1",
     "gray-matter": "^4.0.3",
     "hamburger-react": "^2.4.1",
-    "lodash.sortby": "^4.7.0",
     "next": "^12.0.7",
     "next-auth": "^4.1.0",
     "next-images": "^1.8.4",

diff --git a/pages/search.tsx b/pages/search.tsx
@@ -16,7  16,7 @@ import style from "src/search/search.module.css";
 import Link from "next/link";
 import { useRouter } from "next/router";
 import qs from "qs";
-import sortBy from "lodash.sortBy";
 import { by } from "@pabra/sortby";
 
 const appId = process.env.NEXT_PUBLIC_ALGOLIA_APP_ID || "";
 const apiKey = process.env.NEXT_PUBLIC_ALGOLIA_READ_KEY || "";
@@ -47,7  47,7 @@ export default function Search() {
         <ClearRefinements />
         <RefinementList
           attribute="department"
-          transformItems={(items: any[]) => sortBy(items, "label")}
           transformItems={(items: any[]) => items.sort(by("label"))}
         />
         <Configure hitsPerPage={8} />
         <SearchBox autoFocus />

diff --git a/yarn.lock b/yarn.lock
@@ -398,6  398,11 @@
     "@nodelib/fs.scandir" "2.1.3"
     fastq "^1.6.0"
 
 "@pabra/sortby@^1.0.2":
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/@pabra/sortby/-/sortby-1.0.2.tgz#9ef674da9e5048bbe6a08217ce0dede5411cdfc9"
   integrity sha512-gT4DWbGLlkctE5TwRT6/gZzHiVil1Ywg7FF5OmIilZbGCZqdYpbz98L2bqfhglwK3kj4fBZRMSCtzrjQ6J8jAw==
 
 "@panva/hkdf@^1.0.1":
   version "1.0.1"
   resolved "https://registry.npmjs.org/@panva/hkdf/-/hkdf-1.0.1.tgz"