Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tcplisten to this repo #1926

Closed
gaby opened this issue Dec 18, 2024 · 1 comment · Fixed by #1929
Closed

Migrate tcplisten to this repo #1926

gaby opened this issue Dec 18, 2024 · 1 comment · Fixed by #1929

Comments

@gaby
Copy link
Contributor

gaby commented Dec 18, 2024

@erikdubbelboer I was looking at the code for prefork and notice it uses tcplisten from https://github.com/valyala/tcplisten but that repo is not receiving any updates at all.

It might be worth moving it under this repo to be able to apply improvements like valyala/tcplisten#6 , https://github.com/valyala/tcplisten/pull/10/files and https://github.com/valyala/tcplisten/pull/8/files

Thoughts?
@erikdubbelboer
Copy link
Collaborator

I would be open to a pull request for this.

@ksw2000 ksw2000 mentioned this issue Dec 19, 2024
Merged
erikdubbelboer pushed a commit that referenced this issue Jan 15, 2025
@ksw2000
Migrate valyala/tcplisten to this repo #1926 (#1929)
321b998 
* chore: migrate https://github.com/valyala/tcplisten

* chore: merge upstream PR #6 from valyala/tcplisten: Backport TCP backlog size update of uint16->uint32 with Linux

* chore: merge upstream PR #10 from valyala/tcplisten: add support for dual-stack socket

* refactor: update to modern Go syntax

* doc: update README.md

* refactor: replace valyala/tcplisten package  with custom implementation

* fix: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test

* fix: golangci-lint

* fix: add windows fallback

* fix: prevent integer overflow

* test: skip TestConfigDeferAccept, TestConfigFastOpen, TestConfigAll on non-linux OS

* fix: resolve overflow security issue and use wrapped error

* refactor: migrate from syscall to golang.org/x/sys/unix for better compatibility

* chore: merge upstream PR #8 from valyala/tcplisten: z/OS Compatibility

* refactor: rename tcplisten_bsd.go to tscplisten_other.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate valyala/tcplisten to this repo #1926 ksw2000/fasthttp
2 participants
@erikdubbelboer @gaby