-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isEmail) extend to enable allow_underscores in domain #2229
Conversation
…tion, allowing successful validation of email addresses containing domains with underscores
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2229 /- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2405 2405
Branches 604 604
=======================================
Hits 2404 2404
Partials 1 1
☔ View full report in Codecov by Sentry. |
thanks for the review @WikiRik 1 |
This would be really helpful. |
thanks for the review @rubiin 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
害
Allow successful validation of email addresses containing domains with underscores
Add
allow_underscores
option toisEmail
, pass through value toisFQDN
validator.An example underscore domain in the wild for reference
Checklist