-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IsFQDN): Add a test that asserts numeric chars in tld are rejected by default. #2222
Conversation
Signed-off-by: Aalekh Patel <[email protected]>
Signed-off-by: Aalekh Patel <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2222 /- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2405 2405
Branches 604 604
=======================================
Hits 2404 2404
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we are not testing for solely allow_numeric_tld: true
so this looks good to me. We'll move the other tests for isFQDN
to this file later
Thanks for the PR! |
feat(isFQDN): Add a test that asserts numeric chars in tlds are rejected by default.
Add a test that cements the default behaviour of
isFQDN
of rejecting tld with numeric data, and also that valiation can be relaxed by passing{allow_numeric_tld: true}
Checklist